Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: actually build the topics example in ci #105

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix: actually build the topics example in ci #105

merged 2 commits into from
Dec 13, 2023

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Dec 13, 2023 •
edited
Loading

Topics example should use swift-tools-version 5.7 and CI should actually cd into the topics directory to build the example

@anitarua anitarua requested a review from pgautier404 December 13, 2023 17:24
pgautier404
pgautier404 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@pgautier404 pgautier404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you!

@anitarua anitarua merged commit 3151ee7 into main Dec 13, 2023
4 checks passed
@anitarua anitarua deleted the pr-checks branch December 13, 2023 19:15
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgautier404 pgautier404 pgautier404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitarua @pgautier404