chore: add publish response class and polish publish methods #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
reviewed
Nov 13, 2023
pgautier404
reviewed
Nov 13, 2023
| topicName: String, | ||
| value: String | ||
| ) async -> TopicPublishResponse { | ||
| if cacheName.count < 1 { |
There was a problem hiding this comment.
Swift has an isEmpty string property that may be more idiomatic for this, but both that property and this solution will consider " " valid. I found a neat extension method implementing isBlank we could use, but I think maybe we should hold off on adding and using the extension method until we have validation factored out into it's own class/namespace. This is fine for now but let's revisit when we handle that ticket.
pgautier404
reviewed
Nov 13, 2023
pgautier404
reviewed
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4
Also consolidates the error protocols (based on POC #24) and makes sdk error classes public (#28)