fix: logging for momento clients #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic and cache clients
anitarua
changed the title
cprice404
reviewed
Dec 5, 2023
pgautier404
reviewed
Dec 6, 2023
pgautier404
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #55
Attempt 3
No LogProvider, just the swift-log library
Attempt 2
Uses Apple's swift-log library to create Loggers that can direct logs to any user-specified logging backend. Removed the Momento logger factory files and modified the LogProvider class to keep track of the minimum logging level across all Momento clients and to create new Loggers using that specified level.
Did some local testing and saw logs of the format:
2023-12-04T14:22:02-0800 info PubsubClient : [Momento] initialized loggerAttempt 1
First least worst idea was to allow each client to set their own logger factory within the LogProvider class. This means each client would have to know which logger to call, but it would allow a user to set separate logging levels for their cache and topic clients and all the logic for deciding which logger factory to use is internal.
Open to other suggestions though!