chore: improve pattern matching experience for response types #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgautier404
force-pushed
the
better-pattern-matching
branch
2 times, most recently
from
1a2eec5 to
c831190
Compare
Also adds scalar delete operation and renames control plane response classes to avoid conflicts with data plan response names.
pgautier404
force-pushed
the
better-pattern-matching
branch
3 times, most recently
from
b330d84 to
2d1ed6a
Compare
pgautier404
force-pushed
the
better-pattern-matching
branch
from
2d1ed6a to
7778a94
Compare
anitarua
reviewed
Dec 12, 2023
| Pattern matching can be used to operate on the appropriate subtype. | ||
| ``` | ||
| switch response { | ||
| case let responseError as CacheDeleteError: | ||
| case let responseError as DeleteCacheError: |
There was a problem hiding this comment.
are the code examples in the docstrings going to have to change into enum case matching?
switch response {
case DeleteCacheError.error(let e):
...
case DeleteCacheError.success(let s):
...
}
There was a problem hiding this comment.
I can pick up the task of updating the docstrings here while doing the other docstrings work though
anitarua
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.