fix(Input): move role alert to md-input__message

momentum-design · Sep 18, 2019 · 713cc43 · 713cc43
1 parent 20df1ba
commit 713cc43
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/react/src/lib/Input/index.js b/react/src/lib/Input/index.js
@@ -261,7 +261,7 @@ class Input extends React.Component {
         }
         {inputHelpText && <InputHelper message={inputHelpText} />}
         {messages &&
-          <div className='md-input__messages' role='alert'>
+          <div className='md-input__messages'>
             {messages.map((m, i) => (
               <InputMessage message={m} key={`input-message-${i}`} />
             ))}

diff --git a/react/src/lib/InputMessage/index.js b/react/src/lib/InputMessage/index.js
@@ -6,7 +6,7 @@ import PropTypes from 'prop-types';
 /** Input Message with required message */
 const InputMessage = ({ message }) => {
   return (
-    <div className='md-input__message'>
+    <div className='md-input__message' role='alert'>
       {message}
     </div>
   );

diff --git a/react/src/lib/InputMessage/tests/__snapshots__/input.spec.js.snap b/react/src/lib/InputMessage/tests/__snapshots__/input.spec.js.snap
@@ -22,6 +22,7 @@ ShallowWrapper {
     "props": Object {
       "children": "test",
       "className": "md-input__message",
+      "role": "alert",
     },
     "ref": null,
     "rendered": "test",
@@ -35,6 +36,7 @@ ShallowWrapper {
       "props": Object {
         "children": "test",
         "className": "md-input__message",
+        "role": "alert",
       },
       "ref": null,
       "rendered": "test",