Skip to content

Commit

Permalink
fix(Icon): add title prop to icon element or button if onClick present
Browse files Browse the repository at this point in the history 
BREAKING CHANGE:

1. Icon
  * Remove isAria prop and deprecation warning
  • Loading branch information
@bfbiggs @pauljeter
bfbiggs authored and pauljeter committed Oct 2, 2019
1 parent 47bbc4b commit e736602
Show file tree
Hide file tree
Showing 15 changed files with 23 additions and 277 deletions.
4 changes: 0 additions & 4 deletions react/src/lib/ActivityButton/tests/__snapshots__/index.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="chat_28"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -63,7 +62,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "chat_28",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -98,7 +96,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="chat_28"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -128,7 +125,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "chat_28",
"onClick": null,
"prepend": false,
Expand Down
8 changes: 0 additions & 8 deletions react/src/lib/Alert/tests/__snapshots__/index.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -149,7 +148,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -175,7 +173,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -200,7 +197,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_16",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -264,7 +260,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -356,7 +351,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -382,7 +376,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -407,7 +400,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_16",
"onClick": null,
"prepend": false,
Expand Down
16 changes: 0 additions & 16 deletions react/src/lib/AlertCall/tests/__snapshots__/index.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -260,7 +259,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -292,7 +290,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand All @@ -319,7 +316,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_24",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -409,7 +405,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -566,7 +561,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -598,7 +592,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand All @@ -625,7 +618,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_24",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -817,7 +809,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -1016,7 +1007,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -1048,7 +1038,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand All @@ -1075,7 +1064,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_24",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -1185,7 +1173,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -1384,7 +1371,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -1416,7 +1402,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_24"
onClick={null}
prepend={false}
Expand All @@ -1443,7 +1428,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_24",
"onClick": null,
"prepend": false,
Expand Down
16 changes: 0 additions & 16 deletions react/src/lib/AlertMeeting/tests/__snapshots__/index.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="alarm_16"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -129,7 +128,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -261,7 +259,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="alarm_16"
onClick={null}
prepend={false}
Expand All @@ -288,7 +285,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="alarm_16"
onClick={null}
prepend={false}
Expand All @@ -314,7 +310,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "alarm_16",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -355,7 +350,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -382,7 +376,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -408,7 +401,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_16",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -498,7 +490,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="alarm_16"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -526,7 +517,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -658,7 +648,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="alarm_16"
onClick={null}
prepend={false}
Expand All @@ -685,7 +674,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="alarm_16"
onClick={null}
prepend={false}
Expand All @@ -711,7 +699,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "alarm_16",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -752,7 +739,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -779,7 +765,6 @@ ShallowWrapper {
className=""
color=""
description=""
isAria={true}
name="cancel_16"
onClick={null}
prepend={false}
Expand All @@ -805,7 +790,6 @@ ShallowWrapper {
"className": "",
"color": "",
"description": "",
"isAria": true,
"name": "cancel_16",
"onClick": null,
"prepend": false,
Expand Down
4 changes: 0 additions & 4 deletions react/src/lib/CallControl/tests/__snapshots__/index.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ ShallowWrapper {
className=""
color="white-100"
description=""
isAria={true}
name="microphone-muted_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -65,7 +64,6 @@ ShallowWrapper {
"className": "",
"color": "white-100",
"description": "",
"isAria": true,
"name": "microphone-muted_24",
"onClick": null,
"prepend": false,
Expand Down Expand Up @@ -100,7 +98,6 @@ ShallowWrapper {
className=""
color="white-100"
description=""
isAria={true}
name="microphone-muted_24"
onClick={null}
prepend={false}
Expand Down Expand Up @@ -129,7 +126,6 @@ ShallowWrapper {
"className": "",
"color": "white-100",
"description": "",
"isAria": true,
"name": "microphone-muted_24",
"onClick": null,
"prepend": false,
Expand Down
Loading

0 comments on commit e736602

Please sign in to comment.