-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(accessibility): optionally disable aria-current tag #582
feat(accessibility): optionally disable aria-current tag #582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akashdeep-sarin how many other aria props are there? I like the idea of passing an object for configuration of aria properties but was curious as we have a mostly flat prop structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to update your snapshots and add them to the PR. Tests are failing in CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Address the CI issues, other than that, everything else looks good.
@andrewholsted - We have more than a dozen of aria-* attributes . link, I thought of passing a JSON object, since the behavior of placement of |
@pauljeter - Yes. Will be updating, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akashdeep-sarin is that thought here that we might have other ariaConfig options?
@bfbiggs - Yes... In another usecase, I need (optionally?) specify |
e3b0b65
to
db18eb4
Compare
Added Test Cases |
…sign#582) * feat(accessibility): optionally disable aria-current tag * chore(list): add/update testcases Co-authored-by: Akashdeep Singh <aksinghs@cisco.com>
…sign#582) * feat(accessibility): optionally disable aria-current tag * chore(list): add/update testcases Co-authored-by: Akashdeep Singh <aksinghs@cisco.com>
Some of the accessibility specifications require removal of
aria-current
tag in lists.This tag is displayed on the currently focused
<ListItem>
's.For this, I am suggesting an
ariaConfig
prop which may contain a JSON value for tweaking accessibility properties.Here:
Can be used to stop the population of
aria-current = true
tag.TODOs
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots:
Before (If applicable):
After:
Types of changes
Checklist: