feat(accessibility): optionally disable aria-current tag

[akashdeep-sarin]

Some of the accessibility specifications require removal of aria-current tag in lists.

This tag is displayed on the currently focused <ListItem>'s.

For this, I am suggesting an ariaConfig prop which may contain a JSON value for tweaking accessibility properties.

Here:

const ariaConfiguration = {disableAriaCurrent : true};
<List ariaConfig={ariaConfiguration }> 

Can be used to stop the population of aria-current = true tag.

TODOs

• Write tests
• Update Snapshots

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation update
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Other... Please describe:

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[holsted]

@akashdeep-sarin how many other aria props are there? I like the idea of passing an object for configuration of aria properties but was curious as we have a mostly flat prop structure

[pauljeter]

You need to update your snapshots and add them to the PR. Tests are failing in CI

[yjlo]

Address the CI issues, other than that, everything else looks good.

[akashdeep-sarin]

@andrewholsted - We have more than a dozen of aria-* attributes . link, I thought of passing a JSON object, since the behavior of placement of aria-current tag is handled by the momentum-ui code. In most other cases, the tags are static and dont change their values and/or location in the DOM.
Its just a design decision - can be done otherwise too... by sending a flat props

[akashdeep-sarin]

@pauljeter - Yes. Will be updating,

[bfbiggs]

@akashdeep-sarin is that thought here that we might have other ariaConfig options?

[akashdeep-sarin]

@bfbiggs - Yes... In another usecase, I need (optionally?) specify aria-posinset tags...
I think for such tweaks in ARIA behaviour its better to use a single ariaConfig prop... which can be customized for configuring such behaviour...
Many similar use cases could be possible...

[akashdeep-sarin]

Added Test Cases
Updated Snapshots
Pipeline Passing
Added ariaConfig props to Lists and Menus

Shapshots have been updated