Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Browser Global Element to React Element to make momentum SSR-compatible again #615

Merged
merged 3 commits into from
Jun 17, 2020

Conversation

akoushke
Copy link
Member

@akoushke akoushke commented Jun 16, 2020

SSR applications can not use the latest version of momentum anymore. and the error is caused by this line. I figured to use React Element instead of a Browser global.

Description

change Browser defined Element to React Element.

Related Issue

momentum components are not SSR-compatible anymore.

Motivation and Context

to make momentum SSR compatible agian.

How Has This Been Tested?

yes

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • All new and existing tests passed.

@akoushke akoushke changed the title Remove Element PropType check to make momentum SSR-compatible again Change Browser Defined element to React Element to make momentum SSR-compatible again Jun 16, 2020
@akoushke akoushke changed the title Change Browser Defined element to React Element to make momentum SSR-compatible again Change Browser Global Element to React Element to make momentum SSR-compatible again Jun 16, 2020
@holsted holsted merged commit ee95558 into momentum-design:master Jun 17, 2020
@akoushke akoushke deleted the REMOVE_ELEMENT branch June 17, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants