fix(popover): clear popover delayCheckHover timeout #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robstax
force-pushed
the
popover-timeout-fix
branch
from
bd400ed
to
2eb06ac
Compare
aimeex3
reviewed
Jun 29, 2020
| if (this.props.closeOnFocusLeavesContent) { // if closeOnFocusLeavesContent = true | ||
| if (e.shiftKey) { // SHIFT + TAB | ||
| if (this.props.closeOnFocusLeavesContent) { | ||
| // if closeOnFocusLeavesContent = true |
There was a problem hiding this comment.
don't think we need this comment. seems to repeat the code exactly :)
There was a problem hiding this comment.
i didn't write the comment. formatting the file moved it to the next line :P
aimeex3
approved these changes
Jun 29, 2020
holsted
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
delayCheckHover creates a timeout that we aren't keeping track of, which is a memory leak. this PR fixes that. everything else is formatting noise.
Motivation and Context
Memory leak and address a warning from React when we setState on an unmounted component.
How Has This Been Tested?
it's difficult to consistently repro the issue, but logically this fixes it.
Types of changes
Checklist: