Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(avatar): initials string changes #659

Merged
merged 2 commits into from
Nov 19, 2020

Conversation

akashdeep-sarin
Copy link
Contributor

@akashdeep-sarin akashdeep-sarin commented Nov 4, 2020

Description

Give ability to customize the initials for an avatar
Add additional props for initials.
Use first name and last name for computing initials.

Related Issue

Motivation and Context

Sometimes we need to customize the initials. Eg. We want to use first alphabet of first name and last name.
Current implementation forces initials to be first alphabet of first two words.

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@akashdeep-sarin akashdeep-sarin changed the title feat(avatar): add initials props feat(avatar): initials string changes Nov 6, 2020
give ability to customize the initials for an avatar
@akoushke
Copy link
Member

akoushke commented Nov 6, 2020

I thought title would split it into initials. what is the reason on having initials prop?

@akashdeep-sarin
Copy link
Contributor Author

I thought title would split it into initials. what is the reason on having initials prop?

@akoushke - title does split into initials; initials props is for future needs.

@holsted holsted merged commit 3ea642c into momentum-design:master Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants