Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spacelistmeeting): optional button aria label #724

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

prsaroha
Copy link
Contributor

@prsaroha prsaroha commented Dec 9, 2020

Adding a prop for button aria label so it can be different from button label. If aria label isn't passed, the button label will be used as aria label, which is the current behavior.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

AMANDUA
AMANDUA previously approved these changes Dec 10, 2020
robstax
robstax previously approved these changes Dec 11, 2020
@yjlo yjlo merged commit cdae7a4 into momentum-design:master Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants