-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spacelistmeeting): add props for button tabIndex and className #787
Conversation
2c8dd6c
to
361b0be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should just pass a buttonProps object instead?
I was thinking that, that being a major change requiring refactor for other users of momentum if they update the version, this may not get merged ASAP. If that's not really a concern, I can make the changes. |
1760a79
to
b41d794
Compare
Codecov Report
@@ Coverage Diff @@
## master #787 +/- ##
==========================================
- Coverage 93.81% 93.70% -0.12%
==========================================
Files 131 131
Lines 16276 16276
Branches 2385 2383 -2
==========================================
- Hits 15270 15251 -19
- Misses 1006 1025 +19
Continue to review full report at Codecov.
|
Adding a tabIndex prop and a className prop for the OBTP button.
Description
We need to make the tabIndex of the OBTP button -1, so adding a prop to allow that while keeping 0 as the default value to preserve old behavior. We also need to pass classes sometimes to the button, so a prop was needed for that as well.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots:
Before (If applicable):
After:
Types of changes
Checklist: