Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spacelistmeeting): add props for button tabIndex and className #787

Merged
merged 5 commits into from
Mar 16, 2021

Conversation

prsaroha
Copy link
Contributor

@prsaroha prsaroha commented Feb 24, 2021

Adding a tabIndex prop and a className prop for the OBTP button.

Description

We need to make the tabIndex of the OBTP button -1, so adding a prop to allow that while keeping 0 as the default value to preserve old behavior. We also need to pass classes sometimes to the button, so a prop was needed for that as well.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots:

Before (If applicable):

After:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

dalipkumar703
dalipkumar703 previously approved these changes Feb 24, 2021
@prsaroha prsaroha changed the title feat(spacelistmeeting): add prop for button tabIndex feat(spacelistmeeting): add props for button tabIndex and className Feb 24, 2021
Copy link
Collaborator

@yjlo yjlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should just pass a buttonProps object instead?

@prsaroha
Copy link
Contributor Author

Maybe we should just pass a buttonProps object instead?

I was thinking that, that being a major change requiring refactor for other users of momentum if they update the version, this may not get merged ASAP. If that's not really a concern, I can make the changes.

yjlo
yjlo previously approved these changes Feb 26, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #787 (073f39d) into master (93aa859) will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   93.81%   93.70%   -0.12%     
==========================================
  Files         131      131              
  Lines       16276    16276              
  Branches     2385     2383       -2     
==========================================
- Hits        15270    15251      -19     
- Misses       1006     1025      +19     
Impacted Files Coverage Δ
...ponents/src/components/progress-bar/ProgressBar.ts 86.60% <0.00%> (-13.40%) ⬇️
web-components/src/components/icon/Icon.ts 79.76% <0.00%> (-2.98%) ⬇️
...eb-components/src/components/help-text/HelpText.ts 98.33% <0.00%> (-1.67%) ⬇️
web-components/src/components/input/Input.ts 95.29% <0.00%> (-0.38%) ⬇️
web-components/src/components/tooltip/Tooltip.ts 88.09% <0.00%> (+0.47%) ⬆️
...components/src/components/datepicker/DatePicker.ts 89.72% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93aa859...073f39d. Read the comment docs.

@robstax robstax merged commit 6c22595 into momentum-design:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants