Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Simplify display of confirmations #679

Closed
jonathancross opened this issue Apr 16, 2017 · 7 comments
Closed

[feature request] Simplify display of confirmations #679

jonathancross opened this issue Apr 16, 2017 · 7 comments
Labels

Comments

@jonathancross
Copy link
Contributor

jonathancross commented Apr 16, 2017

After a transaction receives the suggested 10 confirmations, the user is not left with a clear sense that this is now safe / complete.

It would be nice to see a checkmark (or another visual indicator) marking the tx as "confirmed" with the actual number of confirmations added to the "Transaction Details" modal along with "BlockHeight". Could optionally show the number of confirmations on mouseover.

This would allow us to reduce the noise on the main list by removing "BlockHeight".

Thoughts?

@jonathancross jonathancross changed the title [feature request] Add # of confirmations to tx details [feature request] Simplify display of confirmations Apr 16, 2017
@medusadigital
Copy link
Contributor

i like the idea.
also in the same spot is this: #200

so the whole section probably needs a slight redesign.

having something visual to show the confirmations (maybe in form of a clock that fills up like in bitcoinQT) would sure be nice.

however, we shouldnt start working on this before having at least some draft of how things should look like.

if its worth it or if the overall redesign of the whole application should be pushed, that needs to be discussed.

removing blockheight probably wont be possible, since the main sorting is happening there (and the timestamp cant be used)

@jonathancross
Copy link
Contributor Author

having something visual to show the confirmations...

Yeah, this would be great.

removing blockheight probably wont be possible, since the main sorting is happening there (and the timestamp cant be used)

Good point. But why can't the timestamp be used?

@medusadigital
Copy link
Contributor

Good point. But why can't the timestamp be used?

becasue timestamps are set by the miners and can be slightly off:

timestamps

also its much easier to test, since the same default sorting applies in the CLI wallet.

also, we just had issues with the sorting in the past and just chose the easy route due to time pressure: mbg033#70

@dEBRUYNE-1
Copy link
Contributor

+feature

@jonathancross
Copy link
Contributor Author

Thanks for explaining @medusadigital... strange that times they can be so far off.
I need to research how a miner can set a UTC timestamp that is earlier than the previous block. I'd expect this to be rejected.

@selsta
Copy link
Collaborator

selsta commented Apr 27, 2019

The history page looks like this now:

Screenshot 2019-04-27 at 01 59 34

@jonathancross Do you consider this resolved?

@jonathancross
Copy link
Contributor Author

Yes, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants