Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libass support! #409

Closed
vegedb opened this issue Dec 20, 2022 · 5 comments
Closed

Add libass support! #409

vegedb opened this issue Dec 20, 2022 · 5 comments
Labels

Comments

@vegedb
Copy link

vegedb commented Dec 20, 2022

https://github.com/libass/libass
image

As you can see, its weird not to see Just Player in here seeing its open sourced like the others.
ASS/SSA subs is the only thing missing for Just player. Particularly for Anime fans!

Hope you could add it too!

@moneytoo
Copy link
Owner

This is a job for ExoPlayer: google/ExoPlayer#8435 (comment)

@vegedb
Copy link
Author

vegedb commented Dec 20, 2022

@moneytoo
Its an entirely separate entity from exoplayer. Emby and plex (recently added libass) android players both use exoplayer and libass on top of it.

Hope you can look it up.

@vegedb
Copy link
Author

vegedb commented Dec 21, 2022

@vegedb
Copy link
Author

vegedb commented Dec 21, 2022

Configuring subtitle renderer possible in Just player?

Libass is an open source subtitle renderer and a replacement for the VSfilter.

Example,

  1. on MPC-HC, you could change it by pointing to a folder with libass.
  2. on MPV, you could point a "script" folder with latest libass

@moneytoo
Copy link
Owner

moneytoo commented Jan 4, 2023

If there were any publicly available patches/integration of libass in ExoPlayer, I would include them. Unfortunately, no one is sharing that. It would be needed to be implemented in the engine so it's really not a task for Just Player.

@moneytoo moneytoo closed this as completed Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants