Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(NODE-4440): bump TS target version to es2020 #520

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Bump TS target from es5 to es2020. Fixes related to syntax changes.

Is there new documentation needed for these changes?

Yes, see migration guide updates.

What is the motivation for this change?

Modern syntax allows for better control over what we publish (class sytax adds error handling for constructors etc.)

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review November 21, 2022 21:31
@durran durran added the Team Review Needs review from team label Nov 22, 2022
@dariakp dariakp merged commit 491d8b7 into main Nov 22, 2022
@dariakp dariakp deleted the NODE-4440-bump-target branch November 22, 2022 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants