-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(NODE-4706): validate Timestamp ctor argument #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the nit-picky testing suggestions. Just want to keep to the "tests as documentation" mantra and align with our agreed standards. :)
@durran Love the test improvements, I did it locally to make the linter happy with the formatting etc, let me know if I got all the changes in |
Looks great. Thanks! |
@nbbeeken Can we rebase and resolve conflicts? Then I think we're good to merge. |
@durran Updated! |
Description
What is changing?
Completed in this PR as well:
https://jira.mongodb.org/browse/NODE-4705
in
operator workingisObjectLike
, I added tests forisDBRefLike
, but the logic has not been changedbigint
as an input for Timestamp, this already worked at runtime, NODE-4705 was filed to only to remove support for the two low/hight number inputs, so bigint should keep working.What is the motivation for this change?
Double check the following
npm run lint
script<type>(NODE-xxxx)<!>: <description>