Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4870): Support BigInt serialization #541

Merged
merged 19 commits into from
Jan 4, 2023
Merged

feat(NODE-4870): Support BigInt serialization #541

merged 19 commits into from
Jan 4, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Dec 14, 2022 •
edited
Loading

Description

What is changing?

Adding capability to serialize BigInts

Is there new documentation needed for these changes?

Yes. This documentation for this change will be captured in NODE-4871.

What is the motivation for this change?

Allow users to make use of native Javascript BigInts instead of BSON.Long

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests

W-A-James
W-A-James commented Dec 14, 2022
View reviewed changes
test/node/bigint_tests.ts Outdated Show resolved Hide resolved
@W-A-James W-A-James marked this pull request as ready for review December 14, 2022 18:58
nbbeeken
nbbeeken requested changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick first round

test/node/bigint_tests.ts Outdated Show resolved Hide resolved
test/node/bigint_tests.ts Outdated Show resolved Hide resolved
test/node/bigint_tests.ts Outdated Show resolved Hide resolved
test/node/bigint_tests.ts Outdated Show resolved Hide resolved
test/node/bigint_tests.ts Outdated Show resolved Hide resolved
@W-A-James W-A-James changed the title feat(NODE-4870): Begin adding support for bigint serialization feat(NODE-4870): Support BigInt serialization Dec 14, 2022
nbbeeken
nbbeeken requested changes Dec 14, 2022
View reviewed changes
src/parser/serializer.ts Outdated Show resolved Hide resolved
test/node/bigint.test.ts Outdated Show resolved Hide resolved
test/node/bigint.test.ts Outdated Show resolved Hide resolved
test/node/long.test.ts Outdated Show resolved Hide resolved
src/parser/serializer.ts Show resolved Hide resolved
nbbeeken
nbbeeken requested changes Dec 15, 2022
View reviewed changes
test/node/bigint.test.ts Outdated Show resolved Hide resolved
test/node/bigint.test.ts Outdated Show resolved Hide resolved
test/node/bigint.test.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken added the Team Review Needs review from team label Dec 15, 2022
@nbbeeken nbbeeken merged commit e9e40a2 into main Jan 4, 2023
@nbbeeken nbbeeken deleted the NODE-4870/support_bigint64_serialization branch January 4, 2023 14:57
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@durran durran durran approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @durran @nbbeeken