Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4873): support EJSON stringify from BigInt to $numberLong #547

Merged
merged 13 commits into from
Jan 18, 2023
Merged

feat(NODE-4873): support EJSON stringify from BigInt to $numberLong #547

merged 13 commits into from
Jan 18, 2023

Conversation

W-A-James
Copy link
Contributor

@W-A-James W-A-James commented Jan 3, 2023 •
edited
Loading

Description

What is changing?

Adding capability to stringify BigInt

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Allow users to make use of native Javascript BigInts instead of BSON.Long

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests

@W-A-James W-A-James marked this pull request as ready for review January 3, 2023 20:34
nbbeeken
nbbeeken requested changes Jan 3, 2023
View reviewed changes
test/node/extended_json.test.ts Outdated Show resolved Hide resolved
@W-A-James W-A-James force-pushed the NODE-4873/support_ejson_fromBigInt_to_numberLong branch from 77af61e to 3526efd Compare January 4, 2023 15:34
@nbbeeken nbbeeken added the Team Review Needs review from team label Jan 4, 2023
nbbeeken
nbbeeken requested changes Jan 4, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed on slack one more test about loose equality working, and js string == EJSON string

nbbeeken
nbbeeken requested changes Jan 4, 2023
View reviewed changes
src/extended_json.ts Show resolved Hide resolved
nbbeeken
nbbeeken previously approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nbbeeken
nbbeeken previously approved these changes Jan 6, 2023
View reviewed changes
baileympearson
baileympearson requested changes Jan 12, 2023
View reviewed changes
src/extended_json.ts Show resolved Hide resolved
test/node/bigint.test.ts Show resolved Hide resolved
baileympearson
baileympearson approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test output is nicely organized

https://parsley.mongodb.com/evergreen/node_bson_linux_node_tests_v18_patch_3b4b61ed8dfbe7e7f8635e4584e1b17a91c1c4df_63c1bf9032f4171734ce4a31_23_01_13_20_31_14/0/task?bookmarks=0,2871&selectedLine=168

@nbbeeken nbbeeken changed the title feat(NODE-4873): Support EJSON stringify from BigInt to $numberLong feat(NODE-4873): support EJSON stringify from BigInt to $numberLong Jan 18, 2023
@nbbeeken nbbeeken merged commit 37e8690 into main Jan 18, 2023
@nbbeeken nbbeeken deleted the NODE-4873/support_ejson_fromBigInt_to_numberLong branch January 18, 2023 16:42
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@W-A-James @nbbeeken @baileympearson