Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4932): remove .0 suffix from double extended json values #554

Merged
merged 4 commits into from
Jan 10, 2023
Merged

fix(NODE-4932): remove .0 suffix from double extended json values #554

merged 4 commits into from
Jan 10, 2023

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Jan 6, 2023

Description

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review January 10, 2023 21:06
@baileympearson
Copy link
Contributor

same changes as into the 4.0 branch

@baileympearson baileympearson merged commit 946866d into main Jan 10, 2023
@baileympearson baileympearson deleted the NODE-4932-rm-suffix-point-zero-5.0 branch January 10, 2023 21:06
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson