Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUST-954 Pin connections for transactions when connected to a load balancer #461

Merged

Conversation

abr-egn
Copy link
Contributor

@abr-egn abr-egn commented Sep 14, 2021

RUST-954

Transaction connection pinning follows the same rules as mongos pinning for sharded transactions, so this CL augments that machinery to be able to track a PinnedConnectionHandle.

The load balancer spec requires the drivers to track whether a connection is checked out for a cursor vs a transaction vs anything else for the purpose of augmenting the WaitQueueTimeoutError message; however, the Rust driver does not support wait queue timeouts, so I've omitted that tracking.

Copy link
Contributor

@patrickfreed patrickfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@abr-egn abr-egn removed the request for review from isabelatkinson September 15, 2021 18:48
@abr-egn abr-egn merged commit fd0f75c into mongodb:master Sep 15, 2021
awitten1 pushed a commit to awitten1/mongo-rust-driver that referenced this pull request Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants