fix(bulk): fixing retryable writes for mass-change ops

updateMany and deleteMany should not be retryable.
mongodb · Jun 1, 2018 · 0604036 · 0604036
1 parent 4ba5adc
commit 0604036
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/bulk/ordered.js b/lib/bulk/ordered.js
@@ -515,6 +515,17 @@ var executeCommands = function(self, options, callback) {
     finalOptions.checkKeys = false;
   }
 
+  if (finalOptions.retryWrites) {
+    if (batch.batchType === common.UPDATE) {
+      finalOptions.retryWrites = finalOptions.retryWrites && !batch.operations.some(op => op.multi);
+    }
+
+    if (batch.batchType === common.REMOVE) {
+      finalOptions.retryWrites =
+        finalOptions.retryWrites && !batch.operations.some(op => op.limit === 0);
+    }
+  }
+
   try {
     if (batch.batchType === common.INSERT) {
       self.s.topology.insert(

diff --git a/lib/bulk/unordered.js b/lib/bulk/unordered.js
@@ -476,6 +476,17 @@ var executeBatch = function(self, batch, options, callback) {
     finalOptions.checkKeys = false;
   }
 
+  if (finalOptions.retryWrites) {
+    if (batch.batchType === common.UPDATE) {
+      finalOptions.retryWrites = finalOptions.retryWrites && !batch.operations.some(op => op.multi);
+    }
+
+    if (batch.batchType === common.REMOVE) {
+      finalOptions.retryWrites =
+        finalOptions.retryWrites && !batch.operations.some(op => op.limit === 0);
+    }
+  }
+
   try {
     if (batch.batchType === common.INSERT) {
       self.s.topology.insert(