feat: Add MongoOption builder logic #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
b661080
to
0875e3a
Compare
nbbeeken
force-pushed
the
NODE-2698/MongoOptions
branch
from
e61706c
to
956b500
Compare
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
a545f57
to
dcc1e8f
Compare
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
dcc1e8f
to
f311817
Compare
mbroadst
suggested changes
Nov 23, 2020
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
22bdd05
to
5816fa2
Compare
nbbeeken
force-pushed
the
chore/remove-old-options
branch
from
5cdd41b
to
b1fca16
Compare
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
3 times, most recently
from
82d2d81
to
3b0430e
Compare
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
3b0430e
to
956c6a0
Compare
emadum
reviewed
Dec 1, 2020
mbroadst
reviewed
Dec 2, 2020
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
93df27c
to
73988a7
Compare
nbbeeken
commented
Dec 2, 2020
Comment on lines
+149
to
+159
| static merge( | ||
| creds: MongoCredentials, | ||
| options: Partial<MongoCredentialsOptions> | ||
| ): MongoCredentials { | ||
| return new MongoCredentials({ | ||
| username: options.username ?? creds.username, | ||
| password: options.password ?? creds.password, | ||
| mechanism: options.mechanism ?? creds.mechanism, | ||
| mechanismProperties: options.mechanismProperties ?? creds.mechanismProperties, | ||
| source: options.source ?? creds.source ?? options.db | ||
| }); |
There was a problem hiding this comment.
@mbroadst
Sorry about my git fu, I can't reply to your comment about the credentials issue. I've gone ahead with the merge solution, lmk what you think. For what its worth I think we were safe with the spread solution because typescript would not permit us to have a property missing, it just so happens that MongoCredentials and MongoCredentialOptions share all their properties and mandate that they are defined, but ofc better to be safe and box up more complex functionality, so .merge seems like a good solution .
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
73988a7
to
1dd1b8d
Compare
Adds MongoOptions representing the internal view of the specified options. NODE-2698
Parse options from uri and object creating frozen MongoOptions interface object. NODE-2699
nbbeeken
force-pushed
the
NODE-2699/MongoOptions-builder
branch
from
1dd1b8d
to
fe8dffd
Compare
johntseng
added a commit
to johntseng/webonary
that referenced
this pull request
Jun 17, 2022
MongoClientOptions.useNewUrlParser has been removed: mongodb/node-mongodb-native#2623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing options from URI and options object we get a final MongoOptions shaped object, one downside here is that the building process isn't typechecked, doesn't seem like there's an easy way to do that. But the final product is an options property on MongoClient that carries all the top level options specified by the user.
A part of this work revealed a few issues:
minPoolSizeandminSizemight supersede one another and there's no clear way to give priority but also to communicate that priority. I removed the aliasesminSizeandpoolSize.ha,haInterval,domainsEnabled,useUnifiedTopology,useNewUrlParser,appname(notappName), andvalidateOptionsNODE-2699, NODE-2871