feat(NODE-3325): support 'let' option for aggregate command #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for `let` and cherry-pick the tests from mongodb/specifications@3db3879 (since actually updating the full test suite led to a bunch of failures). Since the NODE ticket is scoped to only `aggregate`, nothing else is done here.
|
I’ve mentioned it on the drivers Slack thread about this, but it looks like the sharding failures are because https://jira.mongodb.org/browse/SERVER-46707 regressed somehow. |
|
Server ticket for the sharding failure: https://jira.mongodb.org/browse/SERVER-57403 |
emadum
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What changed?
Add support for
letand cherry-pick the tests from mongodb/specifications@3db3879(since actually updating the full test suite led to a bunch of failures).
Since the NODE ticket is scoped to only
aggregate, nothingelse is done here.
Are there any files to ignore?
Test files are cherry-picked from upstream.