-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-2905): support SERVICE_NAME authentication mechanism property #2857
fix(NODE-2905): support SERVICE_NAME authentication mechanism property #2857
Conversation
'Deprecated (or unknown) options are ignored if replacement exists', | ||
|
||
// We already handle this case in different ways | ||
'may support deprecated gssapiServiceName option (GSSAPI)' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this as it was the last reference to gssapiServiceName
and there is no test with that description anymore.
9229b44
to
539f5eb
Compare
test/manual/kerberos.test.js
Outdated
); | ||
client.connect(function (err) { | ||
expect(err).to.exist; | ||
expect(err.message).to.match(/Error from KDC: LOOKING_UP_SERVER/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing on Evergreen with a different error message than expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah... dumb me did only adapt it for the other test 🙈 should be fixed now!
539f5eb
to
a3aa420
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for that testing documentation! one small style request, otherwise lgtm so I'll leave a ✅
a3aa420
to
4235ec2
Compare
4235ec2
to
26c5367
Compare
This PR adds support for the
SERVICE_NAME
authentication mechanism property that replaces the oldgssapiServiceName
query string parameter.It also includes a test case that would set the
SERVICE_NAME
to an invalid value and verifies the connection consequently fails.NOTE: I've also started a small README file for the manual tests as I was initially unsure on how to run them locally.
Let me know if there's anything I need to adapt 😊