Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-3513): default command monitoring to off #2926

Merged
merged 3 commits into from
Aug 2, 2021

Conversation

nbbeeken
Copy link
Contributor

Revert an accidental default enabling of command monitoring

@dariakp dariakp self-assigned this Aug 2, 2021
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 2, 2021
Copy link
Contributor

@dariakp dariakp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add a sanity test to make sure we can set monitorCommands to true? I also don't see it in this file as part of allURIOptions, but I think it's allowed, so we should probably add a test for setting it both ways.

It looks like there are some tests failing in evergreen with "Cannot read property 'command' of undefined", so they may have been relying on command monitoring being turned on by default

@nbbeeken nbbeeken requested a review from dariakp August 2, 2021 20:31
@dariakp dariakp added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Aug 2, 2021
@dariakp dariakp marked this pull request as ready for review August 2, 2021 20:57
@dariakp dariakp merged commit 3c60245 into 4.0 Aug 2, 2021
@dariakp dariakp deleted the NODE-3513/command-monitoring-default branch August 2, 2021 20:57
ljhaywar pushed a commit that referenced this pull request Nov 9, 2021
* fix(NODE-3513): default command monitoring to off

* fix: tests that expect command monitoring to be on by default

* test: setting monitorCommands to true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants