Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4509): send 1 with hello commands #3508

Merged
merged 4 commits into from
Jan 3, 2023
Merged

feat(NODE-4509): send 1 with hello commands #3508

merged 4 commits into from
Jan 3, 2023

Conversation

durran
Copy link
Member

@durran durran commented Jan 3, 2023 •
edited
Loading

Description

Whenever the driver itself issues a hello or legacy hello, we now set the command value to 1 instead of true.

What is changing?

  • Changes the commands to send 1 instead of true.
  • Changes tests that also send the commands to the same.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4509

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title feat(NODE-4509): send 1 with hello commands feat(NODE-4509)!: send 1 with hello commands Jan 3, 2023
@durran durran changed the title feat(NODE-4509)!: send 1 with hello commands feat(NODE-4509): send 1 with hello commands Jan 3, 2023
@durran durran marked this pull request as ready for review January 3, 2023 18:31
@nbbeeken nbbeeken self-requested a review January 3, 2023 19:00
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Jan 3, 2023
nbbeeken
nbbeeken requested changes Jan 3, 2023
View reviewed changes
src/cmap/connect.ts Show resolved Hide resolved
test/integration/mongodb-handshake/promise_handshake.test.js Outdated Show resolved Hide resolved
@durran durran requested a review from nbbeeken January 3, 2023 19:18
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Jan 3, 2023
@nbbeeken nbbeeken merged commit cc8ea1d into main Jan 3, 2023
@nbbeeken nbbeeken deleted the NODE-4509 branch January 3, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @nbbeeken @baileympearson