Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-5071): support additional time series options #3667

Merged
merged 3 commits into from
May 12, 2023
Merged

feat(NODE-5071): support additional time series options #3667

merged 3 commits into from
May 12, 2023

Conversation

durran
Copy link
Member

@durran durran commented May 11, 2023 •
edited
Loading

Description

Adds support for additional time series options when creating a collection.

What is changing?

  • Updates collection management spec tests.
  • Adds 2 new options to TimeSeriesCollectionOptions, bucketMaxSpanSeconds and bucketRoundingSeconds.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5071/DRIVERS-2546

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran
Copy link
Member Author

durran commented May 11, 2023

New tests passing: https://evergreen.mongodb.com/task_log_raw/mongo_node_driver_next_rhel80_large_node_latest_test_latest_server_patch_41d4f0d8e9944a47e9a1e5385aa3303b921382cc_645d3e1ea4cf477408f7d31f_23_05_11_19_12_31/0?type=T#L2694

@durran durran marked this pull request as ready for review May 11, 2023 19:28
@nbbeeken nbbeeken self-assigned this May 11, 2023
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 11, 2023
@nbbeeken nbbeeken self-requested a review May 11, 2023 20:06
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 11, 2023
@dariakp dariakp merged commit ccf555d into main May 12, 2023
@dariakp dariakp deleted the NODE-5071 branch May 12, 2023 13:31
@github-actions github-actions bot mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@dariakp dariakp dariakp approved these changes

Assignees

@nbbeeken nbbeeken

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @nbbeeken @dariakp