Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-5355): prevent error when saslprep is not a function #3733

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix(NODE-5355): prevent error when saslprep is not a function #3733

merged 2 commits into from
Jun 20, 2023

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Jun 16, 2023 •
edited
Loading

Description

What is changing?

Prevents an error when saslprep is not a function.

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review June 20, 2023 16:58
nbbeeken
nbbeeken requested changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just waiting on confirmation of a manual test, changes LGTM

@baileympearson baileympearson changed the title prevent error when saslprep is not a function fix(NODE-5355): prevent error when saslprep is not a function Jun 20, 2023
@baileympearson baileympearson requested a review from nbbeeken June 20, 2023 19:37
@nbbeeken nbbeeken merged commit 152425a into 3.7 Jun 20, 2023
@nbbeeken nbbeeken deleted the NODE-5355 branch June 20, 2023 19:43
@178masato 178masato mentioned this pull request May 19, 2024
Open
@yochanan-sheinberger yochanan-sheinberger mentioned this pull request May 19, 2024
Open
@boosef-snyk boosef-snyk mentioned this pull request May 21, 2024
Open
@FuryOfTroy FuryOfTroy mentioned this pull request May 22, 2024
Open
@amitsnyk amitsnyk mentioned this pull request May 24, 2024
Open
@andygruber andygruber mentioned this pull request May 24, 2024
Open
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@suellein suellein mentioned this pull request May 24, 2024
Open
@nphan-ca-vn nphan-ca-vn mentioned this pull request May 24, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request May 24, 2024
Open
@techwithmack techwithmack mentioned this pull request May 24, 2024
Open
@snyk-matt snyk-matt mentioned this pull request May 25, 2024
Open
@ramy-abbas ramy-abbas mentioned this pull request May 25, 2024
Open
@VeronicaSnyk VeronicaSnyk mentioned this pull request May 25, 2024
Open
@akshay4850 akshay4850 mentioned this pull request May 25, 2024
Open
@JMR-Mejia JMR-Mejia mentioned this pull request May 26, 2024
Open
@mokdaddy mokdaddy mentioned this pull request May 26, 2024
Open
@WeiLunSnyk WeiLunSnyk mentioned this pull request May 26, 2024
Open
@seyerjin seyerjin mentioned this pull request May 26, 2024
Open
@atearjen atearjen mentioned this pull request May 27, 2024
Closed
@no-amoshe no-amoshe mentioned this pull request May 28, 2024
Open
@frogthehun frogthehun mentioned this pull request Aug 23, 2024
Closed
@officialmofabs officialmofabs mentioned this pull request Sep 6, 2024
Open
@nguyentanvinh7a nguyentanvinh7a mentioned this pull request Sep 7, 2024
Open
@skyairmj skyairmj mentioned this pull request Sep 8, 2024
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Sep 9, 2024
Open
@richyhoopd richyhoopd mentioned this pull request Sep 9, 2024
Open
@Luis-Kristen Luis-Kristen mentioned this pull request Sep 10, 2024
Open
@akhnss akhnss mentioned this pull request Sep 10, 2024
Open
@rodcko rodcko mentioned this pull request Sep 10, 2024
Open
@danilocatapan danilocatapan mentioned this pull request Sep 11, 2024
Open
@rodcko rodcko mentioned this pull request Sep 11, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 12, 2024
Open
@harrisonho99 harrisonho99 mentioned this pull request Sep 13, 2024
Open
@buntyanvi buntyanvi mentioned this pull request Sep 13, 2024
Open
@JMR-Mejia JMR-Mejia mentioned this pull request Sep 13, 2024
Open
@ManuelDevWeb ManuelDevWeb mentioned this pull request Sep 13, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 14, 2024
Open
@danilocatapan danilocatapan mentioned this pull request Sep 15, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 19, 2024
Open
@LeeSangMin1029 LeeSangMin1029 mentioned this pull request Sep 20, 2024
Open
@officialmofabs officialmofabs mentioned this pull request Sep 21, 2024
Open
@LeeSangMin1029 LeeSangMin1029 mentioned this pull request Sep 24, 2024
Open
@ramy-abbas ramy-abbas mentioned this pull request Sep 26, 2024
Open
@lothar2205 lothar2205 mentioned this pull request Sep 27, 2024
Open
@shinramenisbae shinramenisbae mentioned this pull request Oct 12, 2024
Open
This was referenced Oct 12, 2024
Open
Open
@lkeff lkeff mentioned this pull request Oct 24, 2024
Open
@thiagarajanb thiagarajanb mentioned this pull request Oct 27, 2024
Open
@Samax-DevOps Samax-DevOps mentioned this pull request Nov 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baileympearson @nbbeeken