Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-5573): fix saslprep import #3838

Merged
merged 1 commit into from
Aug 23, 2023
Merged

fix(NODE-5573): fix saslprep import #3838

merged 1 commit into from
Aug 23, 2023

Conversation

durran
Copy link
Member

@durran durran commented Aug 23, 2023

Description

Require @mongodb-js/saslprep not saslprep

What is changing?

Fixes the saslprep import.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-5573

Release Highlight

Import of saslprep updated to correct library.

Fixes the import of saslprep to be the correct @mongodb-js/saslprep library.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@addaleax
Copy link
Contributor

The title should refer to NODE-5573, not NODE-5572, right?

@durran durran changed the title fix(NODE-5572): fix saslprep import fix(NODE-5573): fix saslprep import Aug 23, 2023
@W-A-James W-A-James self-assigned this Aug 23, 2023
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Aug 23, 2023
@W-A-James W-A-James merged commit ff6c293 into 4.x Aug 23, 2023
@W-A-James W-A-James deleted the NODE-5573 branch August 23, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants