-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(NODE-4863): do not use RetryableWriteError for non-server errors #3914
fix(NODE-4863): do not use RetryableWriteError for non-server errors #3914
Conversation
…e-write-label-for-non-server-errors
…e-write-label-for-non-server-errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just notes for other reviewers, the testing requirements made it seem to me like the prose test #2 should change somehow, but checking the spec this test matches so no change actually needed there.
The second testing requirement I'm not sure where that came from but I think the additional unit test added here suffices.
Description
Use the
MongoErrorLabel.PoolRequstedRetry
label instead of misusedMongoErrorLabel.RetryableWriteError
for non-server errors according to spec.What is changing?
PoolClearedError
constructor adds the newMongoErrorLabel.PoolRequstedRetry
label instead of misusedMongoErrorLabel.RetryableWriteError
.isRetryableWriteError
function checks if PoolRequstedRetry or RetryableWriteError is set to determine ifretryOperation
is required.Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-4863
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript