Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(NODE-5928): consolidate signal use and abort promise wrap #3992

Merged
merged 2 commits into from
Feb 20, 2024
Merged

perf(NODE-5928): consolidate signal use and abort promise wrap #3992

merged 2 commits into from
Feb 20, 2024

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Consolidate the use of signal in connection layer
  • Create one promise to represent aborting the signal and reuse it
Is there new documentation needed for these changes?

What is the motivation for this change?

Improve the performance of the socketWrite function

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review February 15, 2024 20:32
@nbbeeken nbbeeken force-pushed the NODE-5928-socket-write-perf branch from 0a28ff3 to ef9e103 Compare February 15, 2024 20:33
@durran durran self-assigned this Feb 19, 2024
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 19, 2024
@durran durran added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Feb 19, 2024
@durran durran merged commit 38742c2 into main Feb 20, 2024
25 of 27 checks passed
@durran durran deleted the NODE-5928-socket-write-perf branch February 20, 2024 10:31
@github-actions github-actions bot mentioned this pull request Feb 20, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request May 18, 2024
Open
@lydmoon lydmoon mentioned this pull request May 19, 2024
Open
@lryanle lryanle mentioned this pull request May 21, 2024
Open
@baby636 baby636 mentioned this pull request May 21, 2024
Open
@IdrizMirena IdrizMirena mentioned this pull request May 22, 2024
Open
@mkusztal mkusztal mentioned this pull request May 24, 2024
Open
@NotZarifGithub NotZarifGithub mentioned this pull request May 24, 2024
Open
@arenault-pass arenault-pass mentioned this pull request May 24, 2024
Closed
@lryanle lryanle mentioned this pull request May 24, 2024
Open
@akanchhaS akanchhaS mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 25, 2024
Closed
@lydmoon lydmoon mentioned this pull request May 25, 2024
Open
@boytur boytur mentioned this pull request May 26, 2024
Open
@mkusztal mkusztal mentioned this pull request May 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

Assignees

@durran durran

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @durran