Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(NODE-5919): support new type option in create search index helpers #4060

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

baileympearson
Copy link
Contributor

@baileympearson baileympearson commented Mar 27, 2024

Description

What is changing?

Add support for the type field in SearchIndexDescription. Also syncs the unified search index tests and adds two new search index prose tests, as added in https://jira.mongodb.org/browse/DRIVERS-2768.

Is there new documentation needed for these changes?

What is the motivation for this change?

Release Highlight

type supported in SearchIndexDescription

It is now possible to specify the type of a search index when creating a search index:

const indexName = await collection.createSearchIndex({
  name: 'my-vector-search-index',
  // new! specifies that a `vectorSearch` index is created
  type: 'vectorSearch',
  definition: {
    mappings: { dynamic: false }
  }
});

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson marked this pull request as ready for review April 22, 2024 17:40
@nbbeeken nbbeeken added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 22, 2024
@nbbeeken nbbeeken self-assigned this Apr 22, 2024
nbbeeken
nbbeeken previously approved these changes Apr 22, 2024
@nbbeeken nbbeeken merged commit 3598c23 into mongodb:main Apr 23, 2024
18 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants