feat: add notion of addressbooks

[asbiin]

This adds the notion of Address Book
It's the first step for #2738

This let an account have multiple address book.
The default one is the current solution (with only 1 address book).
The notion of address books is already integrated on carddav.

This PR only address the ability to have multiple address books.
Other PR will gave the opportunity to

• add other distant address books, and add subscription to them
• connect to carddav clients and update them regularly
• display address books content on dashboard

All API functions only address the default address book.

So basically it does not change a lot of things immediatly.

[djaiss]

I don't understand this feature. Can you explain more? Also, I have the feeling it makes the code much more complex, for instance when downgrading, now, as a developer, we will need to think about checking contacts in the address book. Why? How can we make it very simple for developers to not think about that?

[asbiin]

We could add parameters used on the scope function to the Account::contact one, so it will be easy for developers, because account->contact() will be the default address book, and account->contact($id, $abid) will return a specific contact list.
The only limit is to get the ALL contacts of an account. Maybe if addressbookId is -1, it return every contacts.

[tomperrine]

I don't understand this feature. Can you explain more? Also, I have the feeling it makes the code much more complex, for instance when downgrading, now, as a developer, we will need to think about checking contacts in the address book. Why? How can we make it very simple for developers to not think about that?

For example, I have multiple address books - one from O365 at work, a personal gmail account, a consulting email account - I'd like to have all these in Monica, yet be able to manipulate them independently when needed.

[djaiss]

The code in itself is great. That's a good job overall!

However, the concept of Address book adds another layer of abstraction and complexity in the codebase. I don't like this (not the address book, but the added complexity) because the harder our codebase, the harder it is to maintain. We have to fight really really really hard to NOT complexify our codebase if we can. And when we do complexify it, we should make it so the maintenance is really really really easy.

You will see my comments below. What do you think?

[asbiin]

Thanks for the review.
I don't think it adds so complex code .
However, I understand your point, and I tried to simplify it. I guess it's not working for you ...

[github-actions]

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.