Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to attach dates to gifts #4909

Merged
merged 7 commits into from
Mar 21, 2021

Conversation

sktlmarat
Copy link

@sktlmarat sktlmarat commented Feb 22, 2021

Done:

  • Added form to add the date (CreateGift.vue)
  • Date is stored on the database (gift table)

Requires work:

  • Display gift date on dashboard

This close #4710

@sktlmarat
Copy link
Author

Dear @asbiin,

Can I please get your feedback on this PR. I would really appreciate it.

Thanks!

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, see my comments.

I think we should also display the date on display mode (in Gift.vue)
--edit: maybe this is what you meant by "Display gift date on dashboard"?

resources/js/components/people/gifts/CreateGift.vue Outdated Show resolved Hide resolved
@asbiin asbiin changed the title feat: 4710 added ability to attach dates to gifts feat: add ability to attach dates to gifts Mar 21, 2021
Co-authored-by: Alexis Saettler <alexis@saettler.org>
@sktlmarat
Copy link
Author

Hi @asbiin!
That's exactly what I meant by "Display gift date on dashboard".
Thank you for your feedback and addition! All changes were committed.

@asbiin asbiin merged commit da17b8d into monicahq:master Mar 21, 2021
@asbiin
Copy link
Member

asbiin commented Mar 21, 2021

thank you @sktlmarat !

@mgrhm
Copy link

mgrhm commented Mar 21, 2021

This is brilliant -- I just pulled it and I'm able to add dates to gifts I've given.

I'm not sure if I'm missing something, but is there an option to display the dates on the contact’s page? As it stands, the date is correctly recorded but I can only see it when I click 'Edit'.

Screen Shot 2021-03-21 at 18 41 01

@github-actions
Copy link

🎉 This PR is included in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add date field for Gifts
3 participants