Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 4911 broken stay in touch frequency input #4969

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

SimonVanacco
Copy link

Fixes a code typo in master that prevented the frequency input in the stay-in-touch component from showing up.
Closes #4911

Also : i'm new to contributing could you please tell me if i should or shouldn't commit the updated compiled app.js when fixing something ?

Copy link
Member

@asbiin asbiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SimonVanacco that's a good catch, thank you !!

@asbiin
Copy link
Member

asbiin commented Mar 16, 2021

Also : i'm new to contributing could you please tell me if i should or shouldn't commit the updated compiled app.js when fixing something ?

Thank you for your contribution. We want to remove these assets from the repository soon - see #4759. For now we still need them, so that's perfect!

@asbiin asbiin merged commit 500ecc8 into monicahq:master Mar 16, 2021
@github-actions
Copy link

This pull request has been automatically locked since there
has not been any recent activity after it was closed.
Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stay In Touch Broken
2 participants