feat: download and get storage files as private #5192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hq/monica into 20210515-private-avatar-documents
asbiin
changed the title
|
Please retry analysis of this Pull-Request directly on SonarCloud. |
…hq/monica into 20210515-private-avatar-documents
djaiss
reviewed
Jun 21, 2021
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 3.1.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
This pull request has been automatically locked since there |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This close #987
It allows to store photos, avatars, and document privately in s3, and limit access to the file to the only user who owns it.
In addition, we can leverage the browser cache, which will increase speed view of Monica.
You can opt-out to the feature by setting
FILESYSTEM_DEFAULT_VISIBILITYto 'public' - it will be 'private' by default.The cache behavior can be change by defining
DEFAULT_CACHE_CONTROL.