[IPool] - _setDesiredDenorm in memory record update serves no purpose

[cleanunicorn]

Description

The method _setDesiredDenorm sets a desired denorm on the specified token. It first caches the record to the memory.

  function _setDesiredDenorm(address token, uint96 desiredDenorm) internal {
    Record memory record = _records[token];

And later it updates the desiredDenorm on the in-memory structure.

    record.desiredDenorm = desiredDenorm;

However this structure is never used after the update, and at the end of the method execution, the whole structure is discarded. Thus making the update useless.

Recommendation

Remove the line that updates desiredDenorm.

[d1ll0n]

Addressed in indexed-finance/indexed-core#27

Code reference