Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should have an option to open results only on test failure #6

Open
ascagnel opened this issue Apr 15, 2016 · 4 comments
Open

Should have an option to open results only on test failure #6

ascagnel opened this issue Apr 15, 2016 · 4 comments
Labels

Comments

@ascagnel
Copy link

Currently, there is an option is to either always open the results or to never open the results. Ideally, there should also be an option to open the results window only if tests fail.

@monokrome
Copy link
Owner

Thanks for the feedback here, @ascagnel. I'll look into this when I have some time (hopefully soon!). In my tests, I believe that I had this working. Maybe it's related to another setting that I have, though. Going to look into it with a vanilla Vim installation!

Feel free to send a pull request if you have ideas on how this should work, otherwise I'll try to come up with something this week.

Thanks!!!

@monokrome
Copy link
Owner

Hey, @ascagnel.

I think that the intended behavior of always_open_results = 0 is that they still open upon failures. Are you not able to reproduce this expectation?

@monokrome monokrome added the bug label Nov 24, 2016
@ascagnel
Copy link
Author

Sorry for the delay in responding. I was not able to reproduce the expectation using nvim 0.1.5 with the latest version of vim-testdrive installed via Vundle -- failed tests do not open the quickfix or location list windows.

Version info:

» nvim -v
NVIM 0.1.5
Build type: RelWithDebInfo
Compilation: /opt/boxen/homebrew/Library/Homebrew/shims/super/clang -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -DDISABLE_LOG -Wall-Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong
-fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/build/config -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/src -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/deps-build/usr/include -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/deps-build/usr/include -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/deps-build/usr/include -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/deps-build/usr/include -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/deps-build/usr/include -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/deps-build/usr/include -I/opt/boxen/homebrew/opt/gettext/include -I/usr/include -I/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/build/src/nvim/auto -I/tmp/neovim-20160908-61056-d4qfgb/neovim-0.1.5/build/include
Compiled by andrew.scagnelli@Andrew-Scagnellis-Macbook-Pro.local

Optional features included (+) or not (-): +acl   +iconv    +jemalloc +tui
For differences from Vim, see :help vim-differences

   system vimrc file: "$VIM/sysinit.vim"
  fall-back for $VIM: "/opt/boxen/homebrew/Cellar/neovim/0.1.5/share/nvim"

My vimrc file is here: https://github.com/ascagnel/dotfiles/blob/master/.nvimrc

@monokrome
Copy link
Owner

Thanks, @ascagnel! I'll check it out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants