Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with WFRPTableConfig sheet #1200

Closed
Jagusti opened this issue Aug 14, 2022 · 2 comments
Closed

Errors with WFRPTableConfig sheet #1200

Jagusti opened this issue Aug 14, 2022 · 2 comments
Assignees

Comments

@Jagusti
Copy link
Contributor

Jagusti commented Aug 14, 2022

Describe the bug
Template does not show or preserve settings for

  • name, description, icon
  • roll formula
  • options to draw with replacement or display roll to chat
  • table key, table column

A model validation error is thrown, and sometimes other errors (such as no results available)
Console errors are also thrown (see comments).

To Reproduce

  1. Either
    i. Create a new table inside WFRP4e system 6.0.0.9 with a couple of results.
    ii. Import table, eg, Dark Whispers from GM Toolkit.
  2. Open the table if not already open. The name should be a placeholder.
  3. Add a name and roll formula
  4. Roll (without updating).
  5. Replace the name. Update. Settings are cleared, but the name entered is adopted as the application window title. No error is thrown.

The table is drawn from, but settings are reverted.

Tables behave as expected in DnD5e system.

Screenshots
Using WFRP4e Rolltable sheet
image

Using native FTT Rolltable sheet
image

Settings revert after drawing from table
image

Application window title updated
image

Version Numbers
Foundry: 10.277
wfrp4e: 6.0.0.9
GM Toolkit v10 development version

@Jagusti
Copy link
Contributor Author

Jagusti commented Aug 14, 2022

Console errors

foundry.js:55888 Model Validation Errors
[RollTable.name]: may not be a blank string
fetch @ foundry.js:55888
notify @ foundry.js:55815
error @ foundry.js:55851
_preUpdateDocumentArray @ foundry.js:12292
_updateDocuments @ foundry.js:12206
update @ commons.js:6212
await in update (async)
updateDocuments @ commons.js:5567
update @ commons.js:5664
_updateObject @ foundry.js:62353
_onSubmit @ foundry.js:5637
submit @ foundry.js:5928
_onRollTable @ foundry.js:62281
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2

The following error appears with the above

foundry.js:709 Error: RollTable [9rXQv4uJcQoLBitt] Model Validation Errors
[RollTable.name]: may not be a blank string
    at SchemaField._validateType (commons.js:3576:15)
    at SchemaField.validate (commons.js:3303:37)
    at RollTable.validate (commons.js:4925:35)
    at ClientDatabaseBackend._preUpdateDocumentArray (foundry.js:12290:13)
    at ClientDatabaseBackend._updateDocuments (foundry.js:12206:33)
    at ClientDatabaseBackend.update (commons.js:6212:24)
    at async RollTable.updateDocuments (commons.js:5567:23)
    at async RollTable.update (commons.js:5664:23)
onError @ foundry.js:709
_preUpdateDocumentArray @ foundry.js:12293
_updateDocuments @ foundry.js:12206
update @ commons.js:6212
await in update (async)
updateDocuments @ commons.js:5567
update @ commons.js:5664
_updateObject @ foundry.js:62353
_onSubmit @ foundry.js:5637
submit @ foundry.js:5928
_onRollTable @ foundry.js:62281
dispatch @ jquery.min.js:2
v.handle @ jquery.min.js:2

Roll Formula is incorrectly cleared, resulting in the following expected error.

foundry.js:55888 There are no available results which can be drawn from this table.

@Jagusti
Copy link
Contributor Author

Jagusti commented Sep 1, 2022

No longer an issue with FVTT 10.283 and WFRP4e 6.1.1

@Jagusti Jagusti closed this as completed Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants