Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync.rate(), sync.add_to_history() don't pass 'movies', 'shows', etc. keys #21

Closed
charlesreiss opened this issue Aug 15, 2015 · 1 comment

Comments

@charlesreiss
Copy link

The v2 API says sync/ratings and sync/history are supposed to accept a 'movies', 'shows', etc. JSON key with a list of JSON objects, but the code in sync.py simply passes the media object as the top-level JSON entity.

This seemed to silently not add/rate anything when I tried it; as a workaround I wrote my own rate function over @trakt.core.post that did seem to work:

@trakt.core.post
def rate(movie, rating, rating_time):
    data = movie.ids
    data.update(rating=rating, rated_at=rating_time)
    yield 'sync/ratings', {'movies': [data]}

so I don't think I had an auth/etc. problem.

@moogar0880
Copy link
Owner

hey @woggle. Sorry about the delay (been away on vacation for the last week). I have a branch up that I'm pretty sure fixes this issue. Still need to test it out a bit more tomorrow, but hopefully I'll be able to get a fix out for this shortly after that.

Thanks for alerting me to the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants