-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto install-global not working on windows? #296
Comments
The input has
|
@rotu Both of those fail with "program not found". Can you verify that For python, it would be using the I just tested |
My path starts with I don't know how you expect this code to work - it calls |
Does rust not use Let me dig deeper. Edit: Omg it doesn't: https://github.com/rust-lang/rust/blob/master/library/std/src/sys/windows/process.rs#L417 And some context: rust-lang/rust#37381 Let me patch this then. |
Re: #298 Can't we just skip the middleman and have |
proto doesn't know what processes/commands are going to be ran, so no, it cannot use It was built this way so that installing/uninstalling a global can be more than just a child process in the wasm code. If they want, they can run fs operations as well, or modify env vars, etc. |
can you try 0.23.2 |
Gotcha. I can see that the top-level code can't do this. But the call to
Roger! It installs something but the paths seem all incorrect:
But the directory
|
BTW, great job on |
The problem is that we only account for unix paths in the python plugin. Need to add
Looks like another case of windows doing things differently -_- |
Yeh. Also the Python paths I think are relative to the version in use and the node path is not. I don't know which is the better behavior for |
Do you know if theres an arg/env var that we can use for |
Maybe fix for node: moonrepo/node-plugin#22 Will need to test more. |
I think this should do it: |
And maybe also add this to
|
This should fix it: moonrepo/python-plugin#7 But I'll also need to update the proto side to resolve a version so it's not "latest". |
Sweet! FYI, I'm not sure how to update my plugins.python = "github:moonrepo/python-plugin@fix-windows-globals" |
Yeah I'll have to publish a release. Gonna test on my windows machine first just to ensure its right. |
Might not be a bad idea to upload artifacts in the PR CI since we're building it anyway! |
@rotu Yeah I want to figure out a better solution for all this. You could always clone the repo, build locally, and test it too :P |
Testing on my windows machine. We can probably just drop But I'm not sure how to fix Maybe this is a "don't manage python globals in proto" situation.
|
I don’t think we should use the That’s why I suggested The docs mention that packages so installed are tied to the version of python that it pip-installed under. I think that’s what we want! |
Is this still an issue after the latest patch? |
Nope! this issue is fixed! |
Niiice |
What version?
0.23.1
Which command?
proto install-global
What happened?
Installing a global dependency on Windows doesn't seem to work.
proto install-global python pdm
I get a similar issue with
proto install-global node rimraf
.Any logs?
python-debug.log
node-debug.log
Operating system?
Windows
Architecture?
x64
The text was updated successfully, but these errors were encountered: