Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new tag iso8583 in addition to index #281

Closed
alovak opened this issue Sep 8, 2023 · 4 comments
Closed

Support new tag iso8583 in addition to index #281

alovak opened this issue Sep 8, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@alovak
Copy link
Contributor

alovak commented Sep 8, 2023

Using tag index was not a good idea, typically, tags named as json, xml, sql. In the context of this package, it should be named iso8583. Also, when we add more attributes to the tag like "3,keepzero", the name index does not make any sense.

We should support the following: Amount int iso8583:"3,keepzero"and keepindex` for compatibility.

POC for this is implemented here: https://github.com/moov-io/iso8583/pull/273/files

@GalihFajar
Copy link
Contributor

hi @alovak I'd like to work on this issue (I'm currently delving into the repository so can't promise much 🙇 ).

@alovak
Copy link
Contributor Author

alovak commented Oct 6, 2023

@GalihFajar afaik @mfdeveloper508 is working on this issue. You can look at this issue: #292. It doesn't require many changes, and it seems like a good choice for the first issue.

@GalihFajar
Copy link
Contributor

Thanks @alovak, will look onto that one

@alovak
Copy link
Contributor Author

alovak commented Oct 30, 2023

closed in #293

@alovak alovak closed this as completed Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants