You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using tag index was not a good idea, typically, tags named as json, xml, sql. In the context of this package, it should be named iso8583. Also, when we add more attributes to the tag like "3,keepzero", the name index does not make any sense.
We should support the following: Amount int iso8583:"3,keepzero"and keepindex` for compatibility.
@GalihFajar afaik @mfdeveloper508 is working on this issue. You can look at this issue: #292. It doesn't require many changes, and it seems like a good choice for the first issue.
Using tag
index
was not a good idea, typically, tags named asjson
,xml
,sql
. In the context of this package, it should be namediso8583
. Also, when we add more attributes to the tag like"3,keepzero"
, the nameindex
does not make any sense.We should support the following:
Amount int
iso8583:"3,keepzero"and keep
index` for compatibility.POC for this is implemented here: https://github.com/moov-io/iso8583/pull/273/files
The text was updated successfully, but these errors were encountered: