-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/server: expand databases supported to include mysql #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=========================================
- Coverage 58.46% 58.37% -0.1%
=========================================
Files 21 23 +2
Lines 2292 2448 +156
=========================================
+ Hits 1340 1429 +89
- Misses 808 853 +45
- Partials 144 166 +22 |
wadearnold
approved these changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That code change would have required a stack overflow post for me.
This worked for me. The mysql tables were populated. I added a
|
…d_persons to mysql
SQLite handles the previous syntax, but mysql (and postgres) do not. Let's write our code so both databases are handled.
This fixes local tests as records are inserted in sub-second statements.
Collecting metrics every second is way too often.
…connections This caused null pointer calls in CI tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds support for mysql inside of OFAC persistence.
Issue: #94