From 84c945c79fa9ed30df86602eafbb800787c044a5 Mon Sep 17 00:00:00 2001 From: "Moo Yeol, Lee (Prescott)" Date: Thu, 19 Sep 2019 06:58:58 +0900 Subject: [PATCH 1/5] cause lint issues --- index.ts | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/index.ts b/index.ts index 846e458..4693b40 100644 --- a/index.ts +++ b/index.ts @@ -10,6 +10,9 @@ import { Configuration, Linter, RuleSeverity } from "tslint"; const CHECK_NAME = "TSLint Checks"; + + + const SeverityAnnotationLevelMap = new Map([ ["warning", "warning"], ["error", "failure"], @@ -49,6 +52,9 @@ const SeverityAnnotationLevelMap = new Map( formatter: "json", }; + // oops + Math.floor(0x40 >> 4); + // Create a new Linter instance const result = (() => { if (projectFileName && !pattern) { @@ -81,6 +87,8 @@ const SeverityAnnotationLevelMap = new Map( } })(); + console.log("breaking lintp passing"); + const annotations: Octokit.ChecksCreateParamsOutputAnnotations[] = result.failures.map((failure) => ({ path: failure.getFileName(), start_line: failure.getStartPosition().getLineAndCharacter().line, From c2d8efb21b4e36e14a6519c5aeb72972f87c1b81 Mon Sep 17 00:00:00 2001 From: "Moo Yeol, Lee (Prescott)" Date: Thu, 19 Sep 2019 07:05:04 +0900 Subject: [PATCH 2/5] test warning --- tslint.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tslint.json b/tslint.json index 5f27e42..7d193f5 100644 --- a/tslint.json +++ b/tslint.json @@ -6,7 +6,8 @@ "jsRules": {}, "rules": { "object-literal-sort-keys": false, - "interface-name": [true, "never-prefix"] + "interface-name": [true, "never-prefix"], + "no-console": { "severity": "warning" } }, "rulesDirectory": [] } From 3ddcbe6c4ae633e883543812660d22378f36f7b5 Mon Sep 17 00:00:00 2001 From: "Moo Yeol, Lee (Prescott)" Date: Thu, 19 Sep 2019 07:09:58 +0900 Subject: [PATCH 3/5] typo --- index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.ts b/index.ts index 4693b40..98e72b3 100644 --- a/index.ts +++ b/index.ts @@ -87,7 +87,7 @@ const SeverityAnnotationLevelMap = new Map( } })(); - console.log("breaking lintp passing"); + console.log("breaking lint passing"); const annotations: Octokit.ChecksCreateParamsOutputAnnotations[] = result.failures.map((failure) => ({ path: failure.getFileName(), From 48485ad46d4f5d881a4d8eddef0c205fa549e5f0 Mon Sep 17 00:00:00 2001 From: "Moo Yeol, Lee (Prescott)" Date: Thu, 19 Sep 2019 07:13:38 +0900 Subject: [PATCH 4/5] breaking build --- index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/index.ts b/index.ts index 98e72b3..4699f71 100644 --- a/index.ts +++ b/index.ts @@ -53,7 +53,7 @@ const SeverityAnnotationLevelMap = new Map( }; // oops - Math.floor(0x40 >> 4); + Math.floor(0x40 >>> 4); // Create a new Linter instance const result = (() => { From d99b819e028d82090b8a5f4686b1406b9d08bfe4 Mon Sep 17 00:00:00 2001 From: "Moo Yeol, Lee (Prescott)" Date: Thu, 19 Sep 2019 23:25:18 +0900 Subject: [PATCH 5/5] ci(github): use mooyoul/tslint-actions@v1.1.1 --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 114682d..f3e9ab4 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -9,7 +9,7 @@ jobs: - name: Prepare run: npm ci - name: Lint - uses: mooyoul/tslint-actions@master + uses: mooyoul/tslint-actions@v1.1.1 with: token: ${{ secrets.GITHUB_TOKEN }} pattern: '*.ts'