Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install external mobans through requires #89

Merged
merged 19 commits into from
Aug 11, 2018
Merged

Install external mobans through requires #89

merged 19 commits into from
Aug 11, 2018

Conversation

chfw
Copy link
Member

@chfw chfw commented Aug 7, 2018

#35 #86 #87 #88

newsly instroduced "requires":

requires:
   - pypi-mobans-pkg
configuration:
  template_dir:
    - "pypi-mobans-pkg:templates" <-- this is how it is used
    - local
  configuration: config.yml
targets:
  - mytravis.yml: travis.yml.jj2
  - test.txt: demo.txt.jj2

@codecov-io
Copy link

codecov-io commented Aug 7, 2018

Codecov Report

Merging #89 into dev will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev     #89      +/-   ##
=========================================
+ Coverage   98.65%   98.7%   +0.05%     
=========================================
  Files          34      34              
  Lines        1484    1545      +61     
=========================================
+ Hits         1464    1525      +61     
  Misses         20      20
Impacted Files Coverage Δ
moban/copier.py 98.64% <100%> (+0.07%) ⬆️
moban/extensions.py 100% <100%> (ø) ⬆️
tests/test_engine.py 100% <100%> (ø) ⬆️
moban/_version.py 100% <100%> (ø) ⬆️
moban/mobanfile.py 100% <100%> (ø) ⬆️
moban/filters/text.py 100% <100%> (ø) ⬆️
moban/utils.py 97.8% <100%> (+0.1%) ⬆️
moban/constants.py 100% <100%> (ø) ⬆️
tests/test_utils.py 100% <100%> (ø) ⬆️
tests/test_docs.py 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d94e62...2ce7b9c. Read the comment docs.

@chfw chfw requested a review from jayvdb August 7, 2018 21:42
@jayvdb
Copy link
Member

jayvdb commented Aug 8, 2018

Will requires support git URLs?

while releasing a packaging is nice, it isnt dynamic enough.

we need developers to set up a branch of our mobans repo, and be able to use that moban branch as their upstream while developing in other repos, using that un-merged moban enhancement. Once they have it all working well, we merge the moban enhancement and then they re-push their PR in other repos to use the master of the moban repo.

@chfw
Copy link
Member Author

chfw commented Aug 8, 2018

Yes, It will support git urls. I will think about its require syntax and the checkout location.

@chfw
Copy link
Member Author

chfw commented Aug 8, 2018

With pkg, it is possible to have versions. With git repo, it then,as you said allow dynamic synchronization.

@jayvdb
Copy link
Member

jayvdb commented Aug 9, 2018

Ya, I'm very much in favour of proper packaging, and maybe after coala has finished mobanising this will be possible. testpypi might also be a solution for proposed moban enhancements.

I look forward to seeing this also support git , even if it is very basic and not optimised.

@chfw
Copy link
Member Author

chfw commented Aug 9, 2018

Ok. Please approve this PR and I will submit another one for git

@chfw chfw merged commit d8f8f6b into dev Aug 11, 2018
@chfw chfw deleted the moban-requires branch August 11, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants