Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mandatory CHANGELOG.rst #14

Closed
jayvdb opened this issue May 12, 2018 · 4 comments
Closed

Mandatory CHANGELOG.rst #14

jayvdb opened this issue May 12, 2018 · 4 comments

Comments

@jayvdb
Copy link
Member

jayvdb commented May 12, 2018

This repo has a template for CHANGELOG.rst, but setup.py.jj2 should be usable without a CHANGELOG.rst.

I have repos without any history-like file, and others using different filenames. It is quite common for projects to use a variety of solutions for changelogs, and they may not want to have a redundant CHANGELOG.rst just to make use of this setup.py.jj2 template.

I think the neatest easy solution is improve setup.py so that existence of CHANGELOG.rst is checked at runtime, and ignored if not present.

Then setup.py.jj2 can be more used now by people with other solutions for CHANGELOG, and more complicated or alternative solutions for CHANGELOG can then be added if people want to.

@jayvdb
Copy link
Member Author

jayvdb commented May 12, 2018

templates/MANIFEST.in.jj2 also expects a CHANGELOG.rst

@jayvdb jayvdb changed the title setup.py.jj2 assumes CHANGELOG.rst exists Mandatory CHANGELOG.rst May 12, 2018
@chfw
Copy link
Member

chfw commented May 12, 2018

MANIFEST.in.jj2 is a bit hard to include a condition. let me invent something.

@jayvdb
Copy link
Member Author

jayvdb commented May 13, 2018

Ya, separate issue regarding MANIFEST.in.jj2 : #16

@chfw
Copy link
Member

chfw commented Feb 16, 2019

fixed by 2c73a42

@chfw chfw closed this as completed Feb 16, 2019
@chfw chfw mentioned this issue Feb 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants