Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment highlight in iterm #44

Closed
ahmedelgabri opened this issue Jan 24, 2015 · 4 comments
Closed

Remove comment highlight in iterm #44

ahmedelgabri opened this issue Jan 24, 2015 · 4 comments

Comments

@ahmedelgabri
Copy link

I have read the wiki and loaded gruvbox_256palette.sh file in my .zshrc and added g:gruvbox_italic=0 to .vimrc and still as you see in the screenshot, comments are still highlighted. Any idea why?
screen shot 2015-01-25 at 00 38 16

@morhetz
Copy link
Owner

morhetz commented Jan 24, 2015

Whats you output of hi Comment? You should set let g:gruvbox_italic=0 before setting colorscheme gruvbox

@ahmedelgabri
Copy link
Author

Setting let g:gruvbox_italic=0 before colorscheme gruvbox fixed it, thanks!

@ahmedelgabri
Copy link
Author

@morhetz I have a quick question though.

I understand that terminal vim color capabilities are not the same as the GUI and sometime it needs the use of shell files to do this. But there was a discussion here in base-16-vim about this which also uses the shell method to fix colorization. But it looks like iTerm2 fixed an issue related to this and now we don't need to source the shell script if you are using iTerm2. Any plans to do the same, make it work without the need of the shell script?

@morhetz
Copy link
Owner

morhetz commented Jan 26, 2015

TLDR: Nope.
If I got all things right, base-16 guys are using terminal colorscheme with 16-colorspace, which could be done with the gruvbox the same way.
Set up suitable iterm theme and put that to your .vimrc let g:gruvbox_termcolors=16. I'm not really fond of that mostly because this solution forces you to have the same terminal theme and vim theme. It also makes unavailable to switch from gruvbox-dark to gruvbox-light at runtime.
I'm not really aware of base-16 shellscripts, but I suppose they are somehow based on mine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants