Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinuous Lines #116

Merged
merged 1 commit into from
Dec 3, 2012
Merged

Discontinuous Lines #116

merged 1 commit into from
Dec 3, 2012

Conversation

chriserin
Copy link
Contributor

If a data set is [{y: 1}, {y: null}, {y: 3}, {y: 4}] then the graph should only draw a line between 3 and 4. This is for cases where the absence of data is visually important.

A configuration called 'continuousLine' is default to false. If continuousLine is set to true, the graph should draw a line from 1 to 3 to 4, which is the current behavior.

…ted by no line rather than a line connecting only the coords with data.
@oesmith
Copy link
Contributor

oesmith commented Nov 29, 2012

IMHO, the ideal behaviour would be:

  • a null value breaks the line
  • an undefined value does not break the line

To maintain backwards compatibility, this new behaviour will need to be off by default. At the next major release we can drop the old behaviour though, since this is far more sensible.

I'd like to get some pretty comprehensive unit tests around this feature before merging too. I've created a branch (broken-lines) in my repo to work on this.

@chriserin
Copy link
Contributor Author

submitted a pull request to the broken-lines branch... cheers!

@oesmith oesmith merged commit 10826cb into morrisjs:master Dec 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants