Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make line widths customizable #272

Merged
merged 5 commits into from
Oct 12, 2013
Merged

Make line widths customizable #272

merged 5 commits into from
Oct 12, 2013

Conversation

dgilperez
Copy link
Contributor

Hi!

I extended the Morris.Line class to support customization of the line widths when several , in a similar way of point widths and line colors. The use case originating this PR is to be able to draw boundary lines above and under the main depicted line. This will work in a similar way of goals do, but not only horizontal. Example: percentile of growth over age graphs for children.

For the sake of backwards compatibility, I've not changed the attribute name lineWidth for the plural form lineWidth. I also allow both an Array of sizes and a single size to be provided. Is this a good approach?

I hope this is simple enough to be considered for Morris' codebase.

Cheers!

@oesmith oesmith merged commit 8817e22 into morrisjs:master Oct 12, 2013
@oesmith
Copy link
Contributor

oesmith commented Oct 12, 2013

Merged, thanks! I had to make a couple of small changes to work with other contributions, and I altered some variable and config names to read a little easier.

Could you also write some documentation for these changes?

Thanks again 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants