Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: configurable vertical segments #297

Merged
merged 1 commit into from
Jun 14, 2014

Conversation

sudodoki
Copy link
Contributor

Add ability to create vertical grid.
Screenshot of resulting chart:
Screenshot
With next element added to config object:

...
        verticalGrid: {
          condition: function(index) {
            return index % 2
          },
          color: '#888',
          opacity: '0.2'
        }
...

@oesmith
Copy link
Contributor

oesmith commented Nov 9, 2013

Very cool.

Same feedback as before: could you keep the options namespace flat? Thanks!

@sudodoki
Copy link
Contributor Author

Will work on this as soon as I get some time on my hands. Thanks for feedback. Should I also add example page?

@sudodoki
Copy link
Contributor Author

Update PR. Will be doing an example for this one as separate PR.

@sudodoki
Copy link
Contributor Author

In fact. @oesmith, I would love to become a contributor, even if my only help will be with sorting/labeling issues, reviewing PRs, etc. I do understand your position on keeping Morris clean and simple so I wouldn't be pushy around new feature (like #149) though I'd really like to see that and I do value efforts you and others spent to make Morris what it is.

oesmith added a commit that referenced this pull request Jun 14, 2014
feature: configurable vertical segments
@oesmith oesmith merged commit aca2438 into morrisjs:master Jun 14, 2014
@sudodoki sudodoki deleted the feature/vertical_grid branch August 9, 2017 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants